Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IPython as a dependency #1331

Merged
merged 1 commit into from
Nov 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Darts is still in an early development phase, and we cannot always guarantee bac

## [Unreleased](https://github.com/unit8co/darts/tree/master)
- Fixed edge case in ShapExplainer for regression models where covariates series > target series [#1310](https://https://github.com/unit8co/darts/pull/1310) by [Rijk van der Meulen](https://github.com/rijkvandermeulen)
- Removed `IPython` as a dependency. [#1331](https://github.com/unit8co/darts/pull/1331) by [Erik Hasse](https://github.com/erik-hasse)

[Full Changelog](https://github.com/unit8co/darts/compare/0.22.0...master)

Expand Down Expand Up @@ -824,4 +825,4 @@ All implementations of `GlobalForecastingModel`s support multivariate time serie

## Older releases

[Full Changelog](https://github.com/unit8co/darts/compare/f618c4536bf7ed6e3b6a2239fbca4e3089736426...0.2.3)
[Full Changelog](https://github.com/unit8co/darts/compare/f618c4536bf7ed6e3b6a2239fbca4e3089736426...0.2.3)
8 changes: 7 additions & 1 deletion darts/utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,18 @@

import numpy as np
import pandas as pd
from IPython import get_ipython
from joblib import Parallel, delayed
from tqdm import tqdm
from tqdm.notebook import tqdm as tqdm_notebook

from darts import TimeSeries
from darts.logging import get_logger, raise_if, raise_if_not, raise_log

try:
from IPython import get_ipython
except ModuleNotFoundError:
get_ipython = None

logger = get_logger(__name__)


Expand Down Expand Up @@ -88,6 +92,8 @@ def _build_tqdm_iterator(iterable, verbose, **kwargs):
"""

def _isnotebook():
if get_ipython is None:
return False
try:
shell = get_ipython().__class__.__name__
if shell == "ZMQInteractiveShell":
Expand Down
1 change: 0 additions & 1 deletion requirements/core.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
catboost>=1.0.6
holidays>=0.11.1
ipython>=5.0.0
joblib>=0.16.0
lightgbm>=3.2.0
matplotlib>=3.3.0
Expand Down