-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/static covs regression #1412
Conversation
- corrects typo in inference_dataset.py
…ting on series without static covs.
Codecov ReportBase: 93.79% // Head: 93.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 94 94
Lines 9408 9425 +17
=======================================
+ Hits 8824 8840 +16
- Misses 584 585 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! We can merge once the new test is added (and also maybe after we move the new function into tabularization.py
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one @eliane-maalouf !
Fixes #1021.
Summary
Other Information
to test outputs of the function :