Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Literal import for python37 #1449

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Fix Literal import for python37 #1449

merged 1 commit into from
Dec 29, 2022

Conversation

dennisbader
Copy link
Collaborator

Fixes #1444.

Summary

  • fixes Literal import for python3.7

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Base: 93.94% // Head: 93.92% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (b81db0a) compared to base (c52e9d3).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   93.94%   93.92%   -0.03%     
==========================================
  Files         122      122              
  Lines       10723    10713      -10     
==========================================
- Hits        10074    10062      -12     
- Misses        649      651       +2     
Impacted Files Coverage Δ
darts/timeseries.py 91.78% <60.00%> (-0.21%) ⬇️
darts/ad/anomaly_model/filtering_am.py 91.93% <0.00%> (-0.13%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.50% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.27% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hrzn
Copy link
Contributor

hrzn commented Dec 28, 2022

This could warrant a new patch release...

@dennisbader dennisbader merged commit fab7ddf into master Dec 29, 2022
@madtoinou madtoinou deleted the fix/python37_version branch July 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Darts no longer works on python versions lower than 3.8.
3 participants