-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing testing time #1625
Reducing testing time #1625
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 94.13% 94.05% -0.08%
==========================================
Files 125 125
Lines 11340 11326 -14
==========================================
- Hits 10675 10653 -22
- Misses 665 673 +8 see 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot @BlazejNowicki :)
Quick question, just by accumulating the times of all the skipped unit tests, shouldn't the reduced testing time be lower than 7 minutes? (or does it mean in total the testing time will be 11.5 minutes less? :) )
* Marking slow tests * Group torch tests --------- Co-authored-by: Blazej Nowicki <blazej.nowicki@unit8.co>
Fixes #1530.
Summary
Objective of this PR is to reduce testing time locally. Purposed solution marks some of the tests that take the longest so that they can be skipped reducing testing time.
Other information
List of tests that take more than 10 seconds
PyTest
allows to apply markers to tests so that they can be skipped or executed separately.Marked tests
To run other tests
$ pytest -m "not slow"
Running time of tests marked "slow": ~11.5 min
Running time of tests not marked as "slow": ~7 min