-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn user if suspicion of wrong index in from_group_dataframe() #1628
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1628 +/- ##
==========================================
- Coverage 94.13% 94.04% -0.09%
==========================================
Files 125 125
Lines 11306 11294 -12
==========================================
- Hits 10643 10622 -21
- Misses 663 672 +9
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment about the phrasing, to make it even more obvious to the user that a monotonically increasing time index for the whole DataFrame is potentially not what they expect/want.
darts/timeseries.py
Outdated
if time_col is None and df.index.is_monotonic_increasing: | ||
logger.warning( | ||
"UserWarning: `time_col` was not set and `df` has a monotonically increasing (time) index. You can " | ||
"ignore this warning if the index represents the actual index of each individual time series group." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe add something between parentheses saying that a monotonically increasing time index in this context means that the groups have non-overlapping (time) index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…8co#1628) * warn user if suspicion of wrong index in TimeSeries.from_group_dataframe() * imroved warning message --------- Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com>
Fixes #1607.