[DOC] Improve the explanation on the window parameter (offset) of WindowTransformer #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expected by the window parameter of WindowTransformer Add remark to window_transformer file
considering different formats for the parameter window
|
@madtoinou FYI |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1666 +/- ##
==========================================
- Coverage 94.14% 94.05% -0.09%
==========================================
Files 125 125
Lines 11385 11371 -14
==========================================
- Hits 10718 10695 -23
- Misses 667 676 +9
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
madtoinou
reviewed
Mar 27, 2023
darts/tests/dataprocessing/transformers/test_window_transformations.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/transformers/test_window_transformations.py
Outdated
Show resolved
Hide resolved
madtoinou
approved these changes
Mar 27, 2023
dennisbader
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Thank you @JQGoh, looks good! 🚀 I'll merge once tests have passed.
alexcolpitts96
pushed a commit
to alexcolpitts96/darts
that referenced
this pull request
May 31, 2023
…dowTransformer (unit8co#1666) * Improve doc string to clarify the data type of offset expected by the window parameter of WindowTransformer Add remark to window_transformer file * Add test case to demonstrate the transform behaviors, considering different formats for the parameter window * Review: simply use self.assertRaises * Fix failed test --------- Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com> Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1662.
Summary
windowparameter for an offset ispandas.Timedeltadata type instead ofpandas.DateOffset.Other Information
WindowTransformerto demonstrate the mentioned behaviors.