1862 more robust way of component naming #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
- Coverage 94.29% 94.16% -0.14%
==========================================
Files 125 125
Lines 11636 11627 -9
==========================================
- Hits 10972 10948 -24
- Misses 664 679 +15
☔ View full report in Codecov by Sentry. |
dennisbader
requested changes
Jun 28, 2023
There was a problem hiding this comment.
Thanks for this @anne-devries 🚀
Edit: Looks really good! Let's just slightly update the CHANGELOG entry and then we're good to go :)
Co-authored-by: Dennis Bader <dennis.bader@gmx.ch>
dennisbader
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1862 .
Summary
changed category mappings such that static covariate components now are of the form
<original_column_name>_<value1>,<original_column_name>_<value2>, instead of<value1>,<value2>. To account for cases where you have one category that is used by two (or more) static covariates. E.g. temperature could be low/medium/high, and sun_hours could be low/medium/high.