-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix custom module for RNNModel and add tests #2088
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 135 135
Lines 13299 13319 +20
=======================================
+ Hits 12490 12509 +19
- Misses 809 810 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @dennisbader for taking care of this!
Fixes #1523, fixes #2082.
Summary
CustomBlockRNNModule
and:__init__()
)forward()
method and define the logic of your module's forward passBlock/RNNModel
with parametermodel
.forward()
pass instead of the module constructor).