Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the release workflow substantially.
Instead of triggering automatically on pushes to master and creating a draft release, the new release workflow is triggered manually (from the GitHub "Actions" tab in the repo) and requires to provide a "bump type" argument which must be one of
#major, #minor, #patch
(if something else is provided, the release is aborted without making any changes). There was no need for a draft release step anymore, so I removed it.I also removed tests from the release workflow, and instead trigger the merge PR workflow on pushes to master.
To make a release, the new workflow is thus:
#major
, … in the commit message anymore). This triggers the "darts merge PR workflow" which runs the full test suite. Wait for them to successfully run (should be the case since they should have already run on the develop branch), and then…#major
,#minor
or#patch
Everything else should happen automatically and a new release published.
This has the big advantage over the last workflow to be less error-prone (no more problems with forgetting to put the bump type "hastag" in the commit message, …), and to allow pushing minor changes to master without triggering the release workflow (which is the problem we had when updating the readme).
The previous workflow also had a flaw in the sense that it made a commit to master changing the version number in config files before creating the draft pull request, rendering the "draft" release step useless since master had already been altered.