-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/shifted output #2176
Feat/shifted output #2176
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
+ Coverage 93.88% 93.96% +0.08%
==========================================
Files 135 135
Lines 13467 13487 +20
==========================================
+ Hits 12643 12673 +30
+ Misses 824 814 -10 ☔ View full report in Codecov by Sentry. |
Tried this version, and the shift output function works well, but the RNN models cannot work for some reason, where I got message below ```
|
Hi @noahvand, This is intentional because by definition For the sake of uniform API, we could change this but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor comments for the tests.
Nice that this could be implemented so elegantly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
"""Tests shifted output for shift smaller than, equal to, and larger than output_chunk_length. | ||
RNNModel does not support shift output chunk. | ||
""" | ||
# model_cls = TFTModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# model_cls = TFTModel |
…t for parameter shape
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, amazing PR @dennisbader 🚀
Work in progress
Fixes #2139, fixes #2132
Summary
output_chunk_shift
lags=None
andfuture_covariates
with positive only lags andfuture_covariates
starting at or after the first predictable time step.darts.utils.utils.n_steps_between()
to efficiently compute the number of time steps (periods) between two points/timestamps with a given frequency -> improves efficiency for regression model tabularization by avoidingpd.date_range()
.