-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TimesSeries.from_group_dataframe parallel mode #2292
add TimesSeries.from_group_dataframe parallel mode #2292
Conversation
229e095
to
5ef59c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BohdanBilonoh for this neat PR 🚀
This will be a great improvement when dealing with a large number of time series groups :)
I had some minor suggestions on how we could potentially simplify some things here and there.
Also, we're soon to merge PR #2284 which separates the TimeSeries specific utils (will be moved into a new ts_utils.py
) from the non-specific utils.
After that, you can import _parallel_apply
and _build_tqdm_iterator
in timeseries.py
, and also import them in other places as before. We can then remove these changes from this PR.
So I'd say let's ignore my comment about this for now and let's address the other comments first. After we've merged the other PR, we can apply the final changes here.
Thanks for already applying the changes @BohdanBilonoh, it looks great now! 🚀 |
Thanks for review |
#2284 was merged, so we can apply the changes here now 🚀 |
ccf0330
to
a0ce9f3
Compare
945ef3f
to
4ea28f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BohdanBilonoh, for applying the last changes. Great job, this is exactly how I imagined it 🚀 🚀 🚀
Checklist before merging this PR:
Summary
TimeSeries.from_group_dataframe creates time series in for loop. It is suboptimal if the number of groups is large or very large.