Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxml_html_clean for nbshinx #2303

Merged
merged 2 commits into from
Apr 8, 2024
Merged

lxml_html_clean for nbshinx #2303

merged 2 commits into from
Apr 8, 2024

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Apr 8, 2024 •
edited
Loading

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes currently failing docs build unit tests.

Summary

  • lxml.html.clean now has a dedicated package lxml_html_clean that we install

@dennisbader dennisbader merged commit 0604813 into master Apr 8, 2024
7 of 9 checks passed
@dennisbader dennisbader deleted the fix/docs_dependancy_lxml_clean branch April 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madtoinou madtoinou Awaiting requested review from madtoinou madtoinou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dennisbader