fix lighgbm segmentation fault #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisbader
changed the title
madtoinou
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes a segmentation fault when important LightGBMModel.
Summary
LightGBMModel. For some reason importinglightgbmat the wrong place (relative to other dependency imports) can cause this segmentation fault. A fix for this was to importlightgbmat the top in the module/script where the model was used.Darts, I moved theLightGBMModelimport to the top ofdarts/models/__init__.py(see also BUG: Lightgbm tests are failing on MacOS (segmentation fault) shap/shap#3092 which had a similar issue).