Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to be more colorblind friendly #2433

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

jatins
Copy link
Contributor

@jatins jatins commented Jun 28, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #.

Summary

I had trouble differentiation green/red squares in readme, this make it a little more colorblind friendly. I just find/replaced the emojis so the rest of text should be unchanged

Other Information

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @jatins, I think that makes sense :)
Could you add an entry to the changelog? Then we're ready to merge 🚀

README.md Outdated
@@ -218,55 +218,55 @@ Here's a breakdown of the forecasting models currently implemented in Darts. We
on bringing more models and features.



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (5c8b366) to head (20ccc43).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2433      +/-   ##
==========================================
- Coverage   93.79%   93.78%   -0.02%     
==========================================
  Files         138      138              
  Lines       14654    14640      -14     
==========================================
- Hits        13745    13730      -15     
- Misses        909      910       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jatins
Copy link
Contributor Author

jatins commented Jul 5, 2024

@dennisbader thanks for having a look! Changes:

  • Updated the changelog
  • removed redundant whitespace

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jatins, ready to merge 🚀

@dennisbader dennisbader merged commit ecbf203 into unit8co:master Jul 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants