-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to be more colorblind friendly #2433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @jatins, I think that makes sense :)
Could you add an entry to the changelog? Then we're ready to merge 🚀
README.md
Outdated
@@ -218,55 +218,55 @@ Here's a breakdown of the forecasting models currently implemented in Darts. We | |||
on bringing more models and features. | |||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
==========================================
- Coverage 93.79% 93.78% -0.02%
==========================================
Files 138 138
Lines 14654 14640 -14
==========================================
- Hits 13745 13730 -15
- Misses 909 910 +1 ☔ View full report in Codecov by Sentry. |
@dennisbader thanks for having a look! Changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jatins, ready to merge 🚀
Checklist before merging this PR:
Fixes #.
Summary
I had trouble differentiation green/red squares in readme, this make it a little more colorblind friendly. I just find/replaced the emojis so the rest of text should be unchanged
Other Information