Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/optimized hfc prob regr #2534

Merged
merged 6 commits into from
Sep 15, 2024
Merged

Fix/optimized hfc prob regr #2534

merged 6 commits into from
Sep 15, 2024

Conversation

dennisbader
Copy link
Collaborator

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2524.

Summary

  • Fixed a bug when performing probabilistic optimized historical forecasts (num_samples > 1) with a regression models where reshaping the array resulted in a wrong order of samples across components and forecasts.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (41e1177) to head (3ecfc2b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
- Coverage   93.77%   93.76%   -0.02%     
==========================================
  Files         139      139              
  Lines       14765    14751      -14     
==========================================
- Hits        13846    13831      -15     
- Misses        919      920       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 67d4dbd into master Sep 15, 2024
9 checks passed
eschibli pushed a commit to eschibli/darts that referenced this pull request Oct 8, 2024
@madtoinou madtoinou mentioned this pull request Nov 8, 2024
3 tasks
@madtoinou madtoinou deleted the fix/optimized_hfc_prob_regr branch November 11, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Quantiles/samples are wrong when using enable_optimization=True (default!)
1 participant