-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/simple statistics #773
Conversation
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 90.80% 90.29% -0.52%
==========================================
Files 67 68 +1
Lines 6752 6777 +25
==========================================
- Hits 6131 6119 -12
- Misses 621 658 +37
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good, thanks! I added a few comments.
Could you also add some unit tests? Thanks :)
…l axes. Removed dependency on pandas from quantile_timeseries method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #719 .
Summary
Replaced "Simple statistics" methods with new functions that accept stochastic TimeSeries.