-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish TODOs in NHiTs and NBEATs #955
Conversation
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
=======================================
Coverage 92.61% 92.61%
=======================================
Files 74 74
Lines 7404 7423 +19
=======================================
+ Hits 6857 6875 +18
- Misses 547 548 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a lot! I have a couple of minor comments. One of them would be to support a couple more activation functions (the ones in PyTorch that can be easily added). Also how about making the activation configurable in N-BEATS as well, while we're at it? :)
Finally, please add a line to the CHANGELOG.md
file listing the changes. You're most welcome to put your name in there too if you want.
…/darts into fix/nbeats-nhits-TODOs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, new changes look good. I agree it's probably better to leave batch norm out if it seems to perform badly. Could you maybe add/modify a couple of test cases, to integrate a couple of the new parameters?
Co-authored-by: Julien Herzen <j.herzen@gmail.com>
Co-authored-by: Julien Herzen <j.herzen@gmail.com>
@hrzn I added an activation test. let me know if I should add any others |
@hrzn Im going to need some help with the failing test. I don't get any errors on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one, thanks! Will merge.
Fixes #.
#954
Summary
Made NHiTs activation configurable between relu and gelu
Apply NHiTs dropout and batch_norm to NBEATs