Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git ignore all coverage reports #2443

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

cosenal
Copy link
Contributor

@cosenal cosenal commented Jul 7, 2024

E.g. coverage reports with filename .coverage.Alessandros-MacBook.local.* are not git ignored at the moment.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (e61c058) to head (7aa8d6d).
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2443   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files          88       88           
  Lines        4083     4083           
=======================================
  Hits         4030     4030           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosenal cosenal requested review from bdg221 and natestemen July 9, 2024 18:26
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also delete these files when make clean is run. Worth adding here if you agree

mitiq/Makefile

Line 29 in e61c058

rm -rf htmlcov coverage.xml .coverage

Copy link
Collaborator

@bdg221 bdg221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked to see if there were any other files we wanted to ignore as well, but I think we have them all covered now.

I do like Nate's idea of cleaning up the files when make clean is run.

@cosenal
Copy link
Contributor Author

cosenal commented Jul 10, 2024

We should probably also delete these files when make clean is run. Worth adding here if you agree

mitiq/Makefile

Line 29 in e61c058

rm -rf htmlcov coverage.xml .coverage

good catch, addressed in 7aa8d6d

@cosenal cosenal requested review from natestemen and bdg221 July 10, 2024 09:31
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

CI failure is an instance of #2431. okay to merge.

@cosenal cosenal merged commit 7984127 into main Jul 10, 2024
17 of 18 checks passed
@cosenal cosenal deleted the gitignore-all-coverage-reports branch July 10, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants