-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git ignore all coverage reports #2443
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 88 88
Lines 4083 4083
=======================================
Hits 4030 4030
Misses 53 53 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also delete these files when make clean
is run. Worth adding here if you agree
Line 29 in e61c058
rm -rf htmlcov coverage.xml .coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I checked to see if there were any other files we wanted to ignore as well, but I think we have them all covered now.
I do like Nate's idea of cleaning up the files when make clean
is run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
CI failure is an instance of #2431. okay to merge.
E.g. coverage reports with filename
.coverage.Alessandros-MacBook.local.*
are not git ignored at the moment.