Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review RFC for Probabilistic Error Amplification technique #2550

Merged

Conversation

Misty-W
Copy link
Contributor

@Misty-W Misty-W commented Nov 1, 2024

RFC ready for review:
https://docs.google.com/document/d/1l-74EFdMA0CSFUpHjqCyQYb3ZKCmY77seB1_mOZo5Co/edit?tab=t.0

License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@Misty-W Misty-W linked an issue Nov 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (e813b14) to head (09dc6c6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2550   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          92       92           
  Lines        4193     4193           
=======================================
  Hits         4140     4140           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natestemen
Copy link
Member

Purva's comments have been resolved, and I've added mine. Looking good! Should be ready to merge this shortly.

@Misty-W can you add a row to the techniques table in the README to show PEA will be under development?

@purva-thakre
Copy link
Collaborator

@Misty-W Misty-W force-pushed the 2343-new-technique-probabilistic-error-amplification branch from 453ddf3 to bcd5096 Compare December 20, 2024 18:45
@Misty-W
Copy link
Contributor Author

Misty-W commented Dec 20, 2024

@natestemen @purva-thakre this is ready to go in today's release if you agree!

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Misty!

@purva-thakre purva-thakre merged commit b2e2d9b into main Dec 20, 2024
15 of 16 checks passed
@Misty-W Misty-W deleted the 2343-new-technique-probabilistic-error-amplification branch December 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New technique: Probabilistic Error Amplification
3 participants