-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review RFC for Probabilistic Error Amplification technique #2550
Review RFC for Probabilistic Error Amplification technique #2550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2550 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 92 92
Lines 4193 4193
=======================================
Hits 4140 4140
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Purva's comments have been resolved, and I've added mine. Looking good! Should be ready to merge this shortly. @Misty-W can you add a row to the techniques table in the README to show PEA will be under development? |
Also add the RFC here: https://mitiq.readthedocs.io/en/stable/contributing.html#list-of-accepted-rfcs |
RFC ready for review
This reverts commit d6c1cfb.
453ddf3
to
bcd5096
Compare
@natestemen @purva-thakre this is ready to go in today's release if you agree! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Misty!
RFC ready for review:
https://docs.google.com/document/d/1l-74EFdMA0CSFUpHjqCyQYb3ZKCmY77seB1_mOZo5Co/edit?tab=t.0
License
Before opening the PR, please ensure you have completed the following where appropriate.