Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT + ZNE tutorial #2601

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

PT + ZNE tutorial #2601

wants to merge 7 commits into from

Conversation

purva-thakre
Copy link
Collaborator

Description

Fixes #2374


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@purva-thakre
Copy link
Collaborator Author

@natestemen Do you mind taking a quick look at the general outline of this tutorial? I have to clean up the code a bit. So, you could ignore the code blocks for now.

I am not too sure if I need to describe something in excruciating detail as the PT user guide is still WIP.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (0262bfc) to head (b1f04de).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2601   +/-   ##
=======================================
  Coverage   98.72%   98.73%           
=======================================
  Files          92       92           
  Lines        4168     4193   +25     
=======================================
+ Hits         4115     4140   +25     
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natestemen
Copy link
Member

Took a quick look through things and this looks great! I think it's a nice split of theory and practice. I can imagine some of the material working its way in to the user guide, but lets not worry about that for now.

@purva-thakre
Copy link
Collaborator Author

@natestemen The comparison plot is missing data related to only ZNE values.

This is because the circuit I am using is very small for ZNE. If I increase the circuit size used for the comparison plot, the time taken by the tutorial during execution is a lot.

@natestemen natestemen requested a review from cosenal December 17, 2024 16:55
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't finished reading through everything just yet, but wanted to get feedback soon so we can start iterating.

Overall this is a really great mix of theory and practice. Well done setting the bones up.

docs/source/_thumbnails/pt_zne.png Outdated Show resolved Hide resolved
docs/source/examples/examples.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Outdated Show resolved Hide resolved
docs/source/examples/pt_zne.md Show resolved Hide resolved
@cosenal
Copy link
Contributor

cosenal commented Dec 18, 2024

I restarted the RTD build; having a rendered version will make it easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial: Composing techniques: Pauli Twirling and Zero Noise Extrapolation
3 participants