-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PT + ZNE tutorial #2601
base: main
Are you sure you want to change the base?
PT + ZNE tutorial #2601
Conversation
@natestemen Do you mind taking a quick look at the general outline of this tutorial? I have to clean up the code a bit. So, you could ignore the code blocks for now. I am not too sure if I need to describe something in excruciating detail as the PT user guide is still WIP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2601 +/- ##
=======================================
Coverage 98.72% 98.73%
=======================================
Files 92 92
Lines 4168 4193 +25
=======================================
+ Hits 4115 4140 +25
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Took a quick look through things and this looks great! I think it's a nice split of theory and practice. I can imagine some of the material working its way in to the user guide, but lets not worry about that for now. |
@natestemen The comparison plot is missing data related to only ZNE values. This is because the circuit I am using is very small for ZNE. If I increase the circuit size used for the comparison plot, the time taken by the tutorial during execution is a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't finished reading through everything just yet, but wanted to get feedback soon so we can start iterating.
Overall this is a really great mix of theory and practice. Well done setting the bones up.
I restarted the RTD build; having a rendered version will make it easier to review. |
3f6f478
to
cf8b1a5
Compare
Description
Fixes #2374
License
Before opening the PR, please ensure you have completed the following where appropriate.