Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing senators from 116th Congress #168

Merged
merged 5 commits into from
Feb 12, 2019

Conversation

pandringa
Copy link
Contributor

This closes #167 by adding images for Rick Scott, Mitt Romney, Josh Hawley, and Mike Braun.

I used a reverse Google Image search to find full-res, uncropped versions of the Rick Scott and Mike Braun photos, and left a comment in their metadata files to note where the full-res image came from. If there's a better way to denote that, let me know and I'd be happy to fix.

  • I'm acknowledging that my submission is free of all known copyright in at least the United States. (In general, works of the federal government should satisfy this criteria.)

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

We should document the fields a bit better, we're looking for a short noun and a link to whatever the noun refers to (re: #39 (comment)). Maybe something like this?

Co-Authored-By: pandringa <peter9221@gmail.com>
@pandringa
Copy link
Contributor Author

Ah ok, that makes sense - I was a little unclear on what the meta fields were for. Thanks for those corrections!

@hugovk hugovk merged commit d033a13 into unitedstates:gh-pages Feb 12, 2019
@hugovk
Copy link
Member

hugovk commented Feb 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing senators from the 116th congress
2 participants