Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 34 new images of new Congressmen/women (all currently in office) #184

Merged
merged 2 commits into from
Sep 26, 2020
Merged

Adding 34 new images of new Congressmen/women (all currently in office) #184

merged 2 commits into from
Sep 26, 2020

Conversation

Vic-ST
Copy link
Contributor

@Vic-ST Vic-ST commented Sep 25, 2020

  • I'm acknowledging that my submission is free of all known copyright in at least the United States. (In general, works of the federal government should satisfy this criteria.)

Adding 34 new images (of each size type) to their respective folder.

I ran into this issue while running a program to download all current members of congress and wanted to fix it before moving on

@hugovk
Copy link
Member

hugovk commented Sep 25, 2020

Thanks for this!

Please could you also add metadata files in https://github.com/unitedstates/images/tree/gh-pages/congress/metadata ?

@Vic-ST
Copy link
Contributor Author

Vic-ST commented Sep 25, 2020

@hugovk Sure thing, what should they contain?

@hugovk
Copy link
Member

hugovk commented Sep 26, 2020

It should have info on the source of the image, for example:

name: GPO Member Guide
link: http://memberguide.gpo.gov 

https://github.com/unitedstates/images/blob/gh-pages/congress/metadata/A000014.yaml

See also the references in #144

@Vic-ST
Copy link
Contributor Author

Vic-ST commented Sep 26, 2020

Okay, that should be good now.

@hugovk
Copy link
Member

hugovk commented Sep 26, 2020

Great, thanks!

@hugovk hugovk merged commit ac2efb6 into unitedstates:gh-pages Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants