Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gpo_member_photos): regex was returning 0 results #212

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

ryparker
Copy link
Contributor

@ryparker ryparker commented Feb 19, 2022

Summary

This PR fixes the script in scripts/gpo_member_photos.py. Before this PR 0 images would be found when scanning pages for image URLs.

This PR updates the image regex so that it searches the HTML for <a href="/member/[^/]+/(\w+)[^<]+</a></span>.

Old value: <a href="https://www.congress.gov/member/[^/]+/(\w+)[^<]+</a></span>

  • I'm acknowledging that my submission is free of all known copyright in at least
    the United States.
    (In general, works of the federal government should satisfy
    this criteria.)

@ryparker ryparker changed the title fix(gpo_member_photos): regex was returning no results fix(gpo_member_photos): regex was returning 0 results Feb 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #212 (7bd2341) into gh-pages (76394d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           gh-pages     #212   +/-   ##
=========================================
  Coverage     57.42%   57.42%           
=========================================
  Files             2        2           
  Lines           101      101           
=========================================
  Hits             58       58           
  Misses           43       43           
Impacted Files Coverage Δ
scripts/gpo_member_photos.py 46.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76394d3...7bd2341. Read the comment docs.

@hugovk hugovk merged commit ba7776f into unitedstates:gh-pages Feb 19, 2022
@hugovk
Copy link
Member

hugovk commented Feb 19, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants