feat: add collection classes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ronaldtse Some specs are failing because we have yaml with empty values, and no What do you think we should do in this case? |
|
In the serialization we are still getting serialized Ruby objects, eg. |
|
Let’s merge this first. Thanks @HassanAkbar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the specs are failing due to usage with root_mappings.
@HassanAkbar can you please help?
Also, UnitSystems is not working because it is actually a real array. In lutaml-model we don't have a way to map a class to a (real) collection (not a keyed collection).
Also FYI @suleman-uzair .