Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final deliverables #198

Closed
keilw opened this issue Jul 7, 2019 · 8 comments
Closed

Final deliverables #198

keilw opened this issue Jul 7, 2019 · 8 comments
Assignees
Labels
Milestone

Comments

@keilw
Copy link
Member

keilw commented Jul 7, 2019

No description provided.

@keilw keilw added the task label Jul 7, 2019
@keilw keilw added this to the 2.0 milestone Jul 7, 2019
@keilw keilw self-assigned this Jul 7, 2019
@desruisseaux
Copy link
Contributor

What is the deliverable content? Only one single module for the API please!!! (do what you want for the implementation).

@keilw
Copy link
Member Author

keilw commented Jul 7, 2019

No actually there is more, see Harold's forwarded mail to us (the Spec Leads)

keilw added a commit that referenced this issue Jul 7, 2019
keilw added a commit to unitsofmeasurement/unit-tck-usage that referenced this issue Jul 7, 2019
keilw added a commit to unitsofmeasurement/uom-demos that referenced this issue Jul 7, 2019
keilw added a commit to unitsofmeasurement/unit-tck that referenced this issue Jul 8, 2019
@desruisseaux
Copy link
Contributor

@keilw I see that the release at https://github.com/unitsofmeasurement/unit-api/releases/tag/2.0 has 2 Jigsaw module (base and format). Can we please rollback to a single Jigsaw module? I don't see any justification for 2 modules: it does not save memory, does not reduce dependencies, does not simplify implementation.

@keilw
Copy link
Member Author

keilw commented Jul 11, 2019

@desruisseaux What do you mean, it's not in the JAR, which says module java.measure.
Those are optional profiles as seen in #42 (which evolving the POM is not a requirement for 2.0) so no need to unwrap anything. Those profiles are for special cases like Industrial IoT where (just helping a similar use case) embedded devices are rarely doing hot deploy via Maven but require the tiniest space. Unless you work in such an environment, just ignore those profiles, but we offer them to those for having well-defined modules there, too.

@desruisseaux
Copy link
Contributor

Ah, sorry I saw src/etc/modules/format/jdk9/module-info.java and though that it would be the modularization to be deployed on Maven central. If this etc directory is only for profiles, then everything is fine - sorry for disturbing.

@keilw
Copy link
Member Author

keilw commented Jul 11, 2019

No worries, yes, it is only for optimized size in very small embedde environments. Where "base" and "format" are often the only ones they need, "quantity" would be an optional module, but the Java Module System only allows "all or nothing". Everything above that speaks for the "full profile".

keilw added a commit to unitsofmeasurement/seshat that referenced this issue Jul 13, 2019
keilw added a commit to unitsofmeasurement/unit-tck-usage that referenced this issue Jul 13, 2019
@teobais
Copy link
Member

teobais commented Jul 26, 2019

Could this be closed now (given we delivered the Final Release and the ballot was approved :-) ) ?

@keilw
Copy link
Member Author

keilw commented Jul 26, 2019

No, it was approved but the Final deliverables (mostly Spec) are still to be submitted. The binaries would be as they are in Bintray/MavenCentral, but the Spec PDF (2 versions for Implementors and Evaluators) still needs to be sent alongside all those questions.

@keilw keilw closed this as completed Aug 30, 2019
keilw added a commit to unitsofmeasurement/indriya that referenced this issue Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants