Skip to content

Conversation

@nikki-t
Copy link
Contributor

@nikki-t nikki-t commented Jan 30, 2025

Purpose

Revise and update the OGC API Jupyter Notebook to:

  • Make sure it works with the latest SPS code base
  • Add comments to the notebook to provide information and context to describe each step
  • Create a GitBook page that describes and links to the notebook

Pending items:

  • Modify example URL for the top-level proxy OGC API URL
  • Test OGC API with Cognito tokens once that has been implemented

Proposed Changes

  • [ADD] Updates to the OGC API Jupyter Notebook

Issues

Testing

  • Notebook has been run in unity-venue-dev and all output has been capture for each step.

Copy link
Contributor

@LucaCinquini LucaCinquini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikki-t : I tried the JN and it worked, great job. Before merging though please mask the full URL of your personal SPS installation. Also we need to ask @mike-gangl how to fix the validation issues.

@nikki-t
Copy link
Contributor Author

nikki-t commented Feb 6, 2025

Hi @LucaCinquini - I updated the references to the full URL of my SPS deployment so this should be ready once we fix the validation issues.

@nikki-t
Copy link
Contributor Author

nikki-t commented Feb 10, 2025

All checks are passing, please note the software version check was fixed using the utniy-py-python-app.yml from this branch: https://github.com/unity-sds/unity-monorepo/blob/feature/unity-sds-client-update-ds-delete/.github/workflows/unity-py-python-app.yml

@mike-gangl mike-gangl merged commit 9fd5e0a into main Feb 10, 2025
9 checks passed
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13247895957

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.358%

Totals Coverage Status
Change from base Build 13247724945: 0.0%
Covered Lines: 807
Relevant Lines: 1635

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants