Case insensitive collection prefix validation in create_collection #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function call. Fix error in handling response text.
Contributor
|
@mcduffie there is an error in your code (see failed tests). And you'll need to bump the version and update the changelog to allow this merge to proceed. |
version increment. Fix stray quote.
rtapella
reviewed
Mar 5, 2025
Contributor
There was a problem hiding this comment.
Does this PR just fix the exception string? I don't see anything that is changing case sensitivity in this PR.
[EDIT:] My bad, now I see a bunch of changes. For some reason it wasn't showing in the default diff for me before. Or I was asleep or something...
anilnatha
approved these changes
May 19, 2025
mike-gangl
approved these changes
May 19, 2025
rtapella
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Modifies create_collection to not be case sensitive in terms of the base collection_id prefix. But also fix the case of the collection ID submitted to the preferred formatting of all caps.
Issues
Testing
Ran create_collection with different prefix strings.