Skip to content
This repository was archived by the owner on Sep 9, 2024. It is now read-only.

Conversation

@riverma
Copy link
Contributor

@riverma riverma commented Sep 12, 2023

Purpose

Proposed Changes

  • [CHANGE] README contents
  • [ADD] Issue templates and pull request templates

Issues

  • N/A

Testing

@riverma
Copy link
Contributor Author

riverma commented Sep 12, 2023

Note @anilnatha: please add a screenshot of the unity.py tool to the README in the top [INSERT SCREENSHOT... line mentioned here: https://github.com/riverma/unity-py/blame/rverma-patch-1/README.md#L16

@rtapella
Copy link
Collaborator

@riverma for libraries like this… what do you suggest for a screenshot? The pypi web page for unity-sds-client? A screenshot of python code that uses the library? A screenshot of the library code itself? Something else?

@riverma
Copy link
Contributor Author

riverma commented Sep 18, 2023

@riverma for libraries like this… what do you suggest for a screenshot? The pypi web page for unity-sds-client? A screenshot of python code that uses the library? A screenshot of the library code itself? Something else?

Hi @rtapella - thanks for that. Since this is a user-interface of sorts, I was thinking it would be useful to have a screenshot (or GIF!) of say a terminal window and some sample commands in action. Doing so would quickly communicate the utility of using unity-py. What do you think?

@anilnatha
Copy link
Collaborator

@rtapella we spoke of adding code samples in lieu of screenshots, if you're still good with that let me know so that I can remove the placeholder screenshot callout, before approving and merging this PR.

@riverma
Copy link
Contributor Author

riverma commented Oct 4, 2023

@rtapella we spoke of adding code samples in lieu of screenshots, if you're still good with that let me know so that I can remove the placeholder screenshot callout, before approving and merging this PR.

@anilnatha @rtapella - code samples in place of screens is great, probably more useful given the nature of the unity-py tool. LGTM!

Copy link
Collaborator

@rtapella rtapella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I am good with code samples.

@mike-gangl mike-gangl changed the base branch from main to develop December 11, 2023 20:02
@mike-gangl mike-gangl merged commit 797e2a6 into unity-sds:develop Dec 11, 2023
mike-gangl added a commit that referenced this pull request Jan 3, 2024
* Downgrade38 (#59)

* downgrade to support python3.8

* updated poetry version

---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* Pytest (#57)

* adding pytest coverage commands

* remove unneeded python versions form testing

* updated poetry version

* updated coverate command

* Update python-app.yml

added coverall support

* fixed poetry lock

---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* version bump and release fix to use python 3.8 and correct poetry version (#61)

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* Added missing files and improved README (#55)

Co-authored-by: mike-gangl <59702631+mike-gangl@users.noreply.github.com>
Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* 0.2.1 merge (#62) (#63)

* Downgrade38 (#59)

* downgrade to support python3.8

* updated poetry version

---------



* Pytest (#57)

* adding pytest coverage commands

* remove unneeded python versions form testing

* updated poetry version

* updated coverate command

* Update python-app.yml

added coverall support

* fixed poetry lock

---------



* version bump and release fix to use python 3.8 and correct poetry version (#61)



---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* Issues/58 (#64)

* removed un-needed mercury dashboard

* restructured environments to dev/test/prod values

* added environment settings, added process tests (high level) to ensure venue and project setting was successfully available.

* updated unity environments with correct endpoints

* updated changelog

---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>
Co-authored-by: Rishi Verma <riverma@users.noreply.github.com>
mike-gangl added a commit that referenced this pull request Feb 12, 2024
* Downgrade38 (#59)

* downgrade to support python3.8

* updated poetry version

---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* Pytest (#57)

* adding pytest coverage commands

* remove unneeded python versions form testing

* updated poetry version

* updated coverate command

* Update python-app.yml

added coverall support

* fixed poetry lock

---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* version bump and release fix to use python 3.8 and correct poetry version (#61)

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* Added missing files and improved README (#55)

Co-authored-by: mike-gangl <59702631+mike-gangl@users.noreply.github.com>
Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* 0.2.1 merge (#62) (#63)

* Downgrade38 (#59)

* downgrade to support python3.8

* updated poetry version

---------



* Pytest (#57)

* adding pytest coverage commands

* remove unneeded python versions form testing

* updated poetry version

* updated coverate command

* Update python-app.yml

added coverall support

* fixed poetry lock

---------



* version bump and release fix to use python 3.8 and correct poetry version (#61)



---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>

* Issues/58 (#64)

* removed un-needed mercury dashboard

* restructured environments to dev/test/prod values

* added environment settings, added process tests (high level) to ensure venue and project setting was successfully available.

* updated unity environments with correct endpoints

* updated changelog

* fixed json encoding error

* Features/update asset roles (#73)

* Modified the way assets are catalogued so that the asset type is no longer used a key to group assets. Instead an asset role is a piece of metadata for an asset and the fileame of the asset is used as the key.

* Updated changelog and version number.

* We now use the href and not just the filename for the asset key to ensure keys are unique.

* Modified how to handle CMR assets that don't have an asset role specified as metadata key/value pair. In these situations we use the key as the asset role.

* Updated changelog.

* Fixed description in changelog

* added correct client ids for dev, prod

* Updated many methods in Collection to avoid conflating the values needing to be stored for the properties type and roles. Also added new property "roles" to Datafile to assist with the previously mentioned improvement.

* Fixed bug with to_stac method.

* Fixed pluralization with roles key in data_service

---------

Co-authored-by: mike-gangl <michael.e.gangl@jpl.nasa.gov>

* roles is already an array, removed "array of array" (#74)

* Filename key (#75)

* added conversion of asset key to filename if it starts with './'

* smarter basepath naming

---------

Co-authored-by: Anil Natha <anilnatha@users.noreply.github.com>
Co-authored-by: Rishi Verma <riverma@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants