Skip to content

Added a Paths.cmd template so users can add their local VisualStudio … #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

kamgam
Copy link

@kamgam kamgam commented Mar 24, 2024

…version easily. The old one was locked to 2019 enterprise.
I added this because I am using the VS Community Edition and it seems the enterprise path is committed into the Build.cmd file. My solution allows each user to use their own VS path which allows for more flexibility without polluting the branch with differen VS path commits.

…version easily. The old one was locked to 2019 enterprise.
@unitycoder
Copy link
Owner

thanks, ill have a look

@unitycoder
Copy link
Owner

unitycoder commented Mar 27, 2024

would it be possible to make this ready to use by default?

as in: it would default to community version (or detect if it exists) with ready to use/included paths.cmd file,
so then average user doesnt need to do that manual rename and edit?

@kamgam
Copy link
Author

kamgam commented Mar 27, 2024

I think we could check for some default VS paths and use those if no "Paths.cmd" file was set. I'll submit a new PR once I have got that running (don't know yet when I'll have the time to do it though).

@kamgam
Copy link
Author

kamgam commented Apr 3, 2024

Have updated the patch with auto detection for VS 2019 and 2022 Community and Enterprise edition.

It now also prints a proper message for users. I have also added a "PAUSE" command if no VS path could be found (so users notice).

If the Build.cmd is used in an automated build environment then this "pause" behaviour can be disabled by adding "-no-pause" as the first parameter, like: "Build.cmd -no-pause".

@unitycoder unitycoder merged commit f28d954 into unitycoder:master Apr 20, 2024
1 check passed
@unitycoder
Copy link
Owner

added and seems to work locally and with github actions, thanks!

@kamgam
Copy link
Author

kamgam commented Apr 20, 2024

Thanks for merging and making the tool (I use it daily) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants