Resolve enumerable errors are suppressed

[petedavis]

container/src/UnityContainer.Resolution.cs

Line 170 in 7df8bdb

// Ignore

Had an issue using the unity container as a bootstrapper for a simple Nancy app where I could see a two types being registered, but only ever one returned when Resolve<IEnumerable> was called.

Turned out that there was an assembly binding error which was suppressed in the above line.

This issue was identified by switching to the Autofac version of the bootstrapper where it did not hide the exception. I believe that Unity should do the same.

[ENikS]

Unfortunately Resolve<IEnumerable<T>> suppose to swallow all errors and return null or these available items. It should never trow.

This behavior is by design and if changed will make a lot of unhappy people.

[ENikS]

Thinking about it, it should not swallow all exceptions, only specific ones...

[bartoszkp]

@ENikS Thanks for your quick response in #92. The design decision you mention here seems not very readable - perhaps it would be better to have NotThrowingResolve and NotThrowingResolveAll (or maybe ResolveOrNull and ResolveOrNullAll) ? This seems like a major change though.

For this particular case I could propose a solution, but maybe you could first explain which "specific" exceptions you had in mind? Or can I focus on suppressing only the failure in MakeGenericType for now and let all other exceptions through?

[ENikS]

The behavior is implemented to support Generic Constraints. The implementation incorrectly catches all exceptions instead of catching only these, related to failed constraints.
I will fix it in next patch release v5.8.7

[ENikS]

@bartoszkp PR?