Fix server list being dropped when invalid ip is provided by a single server #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corp-0
reviewed
Mar 6, 2023
This was referenced Mar 6, 2023
CorruptComputer
commented
Mar 9, 2023
corp-0
force-pushed
the
domain-in-ip-field
branch
from
051e667 to
c6cda0a
Compare
corp-0
approved these changes
Mar 9, 2023
…logging for server fetching
corp-0
force-pushed
the
domain-in-ip-field
branch
from
c6cda0a to
2c187a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should also allow you to join a server using a domain name instead of an IP address. Tested using
natsuko.ninjafor Wild Frontier FFA, and I was able to join and play without issues.Fixes #161