Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes action icons not despawning after death #6431

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

Semuca
Copy link
Contributor

@Semuca Semuca commented Apr 28, 2021

Purpose
When you died, action icons like toggling the PDA light would remain as you were a ghost, and even remain when you respawned, so I modified the scriptable object so they despawn on death. Only certain items needed this change, because other items like bags have icons that only appear when the item is in your hands and you automatically drop what you're holding when you die when you die (disabling the icon).

Changelog:
CL: Fixed action icons not disappearing after death

@corp-0
Copy link
Member

corp-0 commented Apr 28, 2021

can you briefly explain how the fix works?

@NoooneyDude
Copy link
Contributor

NoooneyDude commented Apr 29, 2021

Listens to the networked event local player died, disabling the action button when triggered.

@Semuca what happens if the player's corpse is revived?

@Semuca
Copy link
Contributor Author

Semuca commented Apr 29, 2021

Yup, from my testing it works when a player is revived

@NoooneyDude
Copy link
Contributor

Yup, from my testing it works when a player is revived

Awesome, thank you.

@NoooneyDude NoooneyDude merged commit c99d50e into unitystation:develop Apr 29, 2021
@PerfectTangent
Copy link
Contributor

PerfectTangent commented May 1, 2021

the buckled icon failed to disappear when I aghosted, when I killed myself, and when I respawned. Tested on staging.

@Semuca Semuca deleted the uifix branch May 17, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants