Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #1516

Merged
merged 1 commit into from
Aug 19, 2017
Merged

docs: fix typos #1516

merged 1 commit into from
Aug 19, 2017

Conversation

jwilk
Copy link
Contributor

@jwilk jwilk commented Jul 29, 2017

Found using mwic and anorack.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.373% when pulling 4711ae3 on jwilk-forks:spelling into 5567535 on universal-ctags:master.

@masatake masatake self-requested a review August 1, 2017 15:11
@@ -84,7 +84,7 @@ If you want to build a debug version, you must specify ``DEBUG=1`` like below::

From their site: MSYS is a collection of GNU utilities such as bash, make, gawk and grep to allow building of applications and programs which depend on traditional UNIX tools to be present. It is intended to supplement MinGW and the deficiencies of the cmd shell.

MSYS comes in two flavors. The original from MinGW and a MSYS2 http://sourceforge.net/projects/msys2/
MSYS comes in two flavors. The original from MinGW and an MSYS2 http://sourceforge.net/projects/msys2/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-takata, how do you think about this?

I think a or an is not an issue, here.
I guess the correct sentence may be MSYS comes in two flavors: the original from MinGW and MSYS2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-takata, thank you for the confirmation.

@jwilk, I will fix the sentence I commented here after merging your change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@masatake
Copy link
Member

masatake commented Aug 1, 2017

Very impressive. Thank you.

Could you add how do you run mwic and anorack? I would like to add targets to run them to Makefile.

@masatake masatake merged commit 0129125 into universal-ctags:master Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants