Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-posix make flag --no-print-directory from autogen.sh #1556

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Sep 20, 2017

This fixes the remaining BSD build issues after the recent bmake fixes
were merged into master. Discussed in #1554. Closes #1554.

This fixes the remaining BSD build issues after the recent bmake fixes
were merged into master. Discussed in universal-ctags#1554. Closes universal-ctags#1554.
@mqudsi mqudsi changed the title Removed non-posix make flag --no-print-directory from autogen.sh Remove non-posix make flag --no-print-directory from autogen.sh Sep 20, 2017
@mqudsi
Copy link
Contributor Author

mqudsi commented Sep 20, 2017

Just for reference, as seen in the GNU Make man page:

       -w, --print-directory
            Print a message containing the working directory before and after
            other processing.  This may be useful for tracking down errors
            from complicated nests of recursive make commands.

       --no-print-directory
            Turn off -w, even if it was turned on implicitly.

I'm not sure what implicitly turns on -w. Perhaps -d which prints debugging info (which isn't specified). We should be OK without --no-print-directory.

@masatake
Copy link
Member

LGTM.

@codebrainz
Copy link
Contributor

I'm not sure what implicitly turns on -w.

It's explained somewhat in the online docs after the part you quoted:

Print a message containing the working directory both before and after executing the makefile. This may be useful for tracking down errors from complicated nests of recursive make commands. See Recursive Use of make. (In practice, you rarely need to specify this option since ‘make’ does it for you; see The ‘--print-directory’ Option.)

So I guess because of the -f it's considered a submake, or maybe because of the specified make file including other make files. Either way, it's definitively the default behaviour I've observed in my own Make files.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.941% when pulling 34dba7b on mqudsi:autogen_compat into 51699aa on universal-ctags:master.

@masatake masatake self-assigned this Sep 21, 2017
@masatake masatake merged commit b953728 into universal-ctags:master Sep 21, 2017
@masatake
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants