-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: new parser #1818
CMake: new parser #1818
Conversation
win32/ctags_vs2013.vcxproj.filters
Outdated
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change for the end of file should not be added. git add -p may help you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. That's my editor being too smart for its own good. I'll fix it.
Other than one minor point about the build file for windoes. everything looks good to me. After visiting your profile page I know why you needs cmake parser; you are a wireshark hacker. |
( I run "make chop LANGUAGES=CMake", "make slap LANGUAGES=CMake", and "make fuzz LANGUAGES=CMake". All are passed.) |
The techniques used in the cmake.ctags are impressive. I have to consider applying them to my PuppetManifest parser. |
There's no namespace concept in CMake - they do have a concept of "scope", but not in the sense that ctags would care I think (other than the Do you think I should try to add the scope for variable tags within functions/macros? (ie, use |
optlib/cmake.ctags
Outdated
# | ||
# variable | ||
# | ||
--_mtable-regex-CMake=variable/([A-Za-z0-9_.-]+)([# \t\n\)])/\1/v/{tleave}{advanceTo=2start} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug: all these {advanceTo=2start}
should be {_advanceTo=2start}
Could you squash 08c4658 to acdd8 ? |
Would you mind if I just squashed all my changes down to one commit? It would be easier. |
Merging it one ("CMake: new parser") is o.k. |
As mentioned in issue universal-ctags#1816, this is a CMake file parser using the optlib multitable regex feature.
66c62e0
to
806f296
Compare
Done. |
Thank you! |
As mentioned in issue #1816, this is a CMake file parser using the optlib multitable regex feature.