Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: improve mixin detection #2483

Merged

Conversation

masatake
Copy link
Member

@masatake masatake commented Apr 2, 2020

  • detect method style mixin as suggested in Ruby: extend mixin field #2481, and
  • ignore unnamed blocks like "while", "if", ... when detecting mixing method invocations.

masatake added 3 commits April 2, 2020 20:38
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 86.714% when pulling ea87271 on masatake:ruby-improve-mixin-detection into 513872a on universal-ctags:master.

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #2483 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2483   +/-   ##
=======================================
  Coverage   86.60%   86.61%           
=======================================
  Files         177      177           
  Lines       36763    36774   +11     
=======================================
+ Hits        31839    31850   +11     
  Misses       4924     4924           
Impacted Files Coverage Δ
main/nestlevel.c 87.50% <100.00%> (-0.26%) ⬇️
parsers/ruby.c 98.12% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999a44a...ea87271. Read the comment docs.

@masatake masatake merged commit 841a3bf into universal-ctags:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants