Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: parse member variables using templates with forward declared types #2869

Merged
merged 1 commit into from
Apr 19, 2021
Merged

C++: parse member variables using templates with forward declared types #2869

merged 1 commit into from
Apr 19, 2021

Conversation

drichardson
Copy link
Contributor

Fixes #2867.

@drichardson drichardson mentioned this pull request Feb 15, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 15, 2021 •
edited
Loading

Codecov Report

Merging #2869 (6dd35ca) into master (3185b28) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6dd35ca differs from pull request most recent head 9b9bf47. Consider uploading reports for the commit 9b9bf47 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2869   +/-   ##
=======================================
  Coverage   87.16%   87.17%           
=======================================
  Files         194      194           
  Lines       44407    44416    +9     
=======================================
+ Hits        38709    38718    +9     
  Misses       5698     5698
Impacted Files Coverage Δ
parsers/cxx/cxx_parser_block.c 85.62% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3185b28...9b9bf47. Read the comment docs.

@masatake
Copy link
Member

Thank you. Could you squash the changes into one commit?
In addition, I would like you to use C++: ... as the prefix for the commit log.

@masatake masatake requested a review from pragmaware February 16, 2021 01:06
@drichardson drichardson force-pushed the template-member-forward-decl branch 2 times, most recently from 45fca9f to 97d2a2c Compare February 16, 2021 02:23
@drichardson
Copy link
Contributor Author

Thank you. Could you squash the changes into one commit?
In addition, I would like you to use C++: ... as the prefix for the commit log.

Done and done.

@masatake
Copy link
Member

Thank you.
Let's wait for the maintainer to find the time for review:-)

@masatake masatake changed the title Parse member variables using templates with forward declared types C++: parse member variables using templates with forward declared types Feb 16, 2021
masatake
masatake requested changes Apr 1, 2021
View reviewed changes
parsers/cxx/cxx_parser_block.c Outdated
@@ -262,6 +262,7 @@ static bool cxxParserParseBlockInternal(bool bExpectClosingBracket)
cppBeginStatement();
}

int in_triangle = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the local variable to iNestedAngleBracketLevel ?
The parser maintainer may prefer the naming scheme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@masatake
Copy link
Member

masatake commented Apr 1, 2021

@pragmaware, could you look at this one?

@masatake
Copy link
Member

masatake commented Apr 1, 2021 •
edited
Loading

@drichardson, sorry for being late.
I would like you to change the local variable. Could you fix it and push --force again?
If we cannot get a comment from the parser maintainer in a week, I will merge this.

@drichardson drichardson force-pushed the template-member-forward-decl branch from 97d2a2c to 9b9bf47 Compare April 1, 2021 17:47
@drichardson
Copy link
Contributor Author

drichardson commented Apr 1, 2021 •
edited
Loading

I would like you to change the local variable. Could you fix it and push --force again?

Done.

@masatake
Copy link
Member

masatake commented Apr 1, 2021

Thank you.

@drichardson
Copy link
Contributor Author

Time to merge?

@masatake
Copy link
Member

I will merge this.
@pragmaware, please look at this when you find a time.

@masatake masatake merged commit 3b0e4ee into universal-ctags:master Apr 19, 2021
@masatake
Copy link
Member

@drichardson, thank you for the contribution.

@drichardson drichardson deleted the template-member-forward-decl branch June 16, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masatake masatake masatake approved these changes

@pragmaware pragmaware Awaiting requested review from pragmaware

Assignees

@masatake masatake

@pragmaware pragmaware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++ parser does not tag member variable if type is template with forward declared class
3 participants
@drichardson @masatake @pragmaware