Ada : fixed cppcheck errors + added ada-label test

[koenmeersman]

cppcheck

errors fixed:

parsers/ada.c:497:41: style: Condition 'token->prev==NULL' is always true [knownConditionTrueFalse]
parsers/ada.c:493:20: note: Assuming that condition 'token->prev!=NULL' is not redundant
parsers/ada.c:497:41: note: Condition 'token->prev==NULL' is always true
parsers/ada.c:507:41: style: Condition 'token->next==NULL' is always true [knownConditionTrueFalse]
parsers/ada.c:503:20: note: Assuming that condition 'token->next!=NULL' is not redundant
parsers/ada.c:507:41: note: Condition 'token->next==NULL' is always true
parsers/ada.c:2025:19: style: Variable 'token' is reassigned a value before the old one has been used. [redundantAssignment]
parsers/ada.c:2023:19: note: token is assigned
parsers/ada.c:2025:19: note: token is overwritten

False error:

Following error is false error (The function 'skipPastKeywordOrWord' is used)

parsers/ada.c:944:0: style: The function 'skipPastKeywordOrWord' is never used. [unusedFunction]

Added label test

Improving coverage from:

  File 'parsers/ada.c'
  Lines executed:73.10% of 788
  Creating 'ada.c.gcov'

to:

  File 'parsers/ada.c'
  Lines executed:80.46% of 788
  Creating 'ada.c.gcov'

[codecov]

Codecov Report

Merging #2946 (11ccf0b) into master (8933d0f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 11ccf0b differs from pull request most recent head 588aa20. Consider uploading reports for the commit 588aa20 to get more accurate results

@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
+ Coverage   87.16%   87.24%   +0.07%     
==========================================
  Files         194      194              
  Lines       44421    44422       +1     
==========================================
+ Hits        38719    38755      +36     
+ Misses       5702     5667      -35     

Impacted Files	Coverage Δ
parsers/ada.c	80.43% <100.00%> (+4.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8933d0f...588aa20. Read the comment docs.

[masatake]

Thank you.
Could you consider being a maintainer of Ada parser?

[masatake]

I cannot find time for working on Ada parser now.
However, it seems that you can fix the issues you reported.
So I invited you to this project. Even if you reject the invitation, I will fix the issues you reported with your help. However, you have to wait till I find the time.

[koenmeersman]

Maintainer or Ada parser, I'm not seeing myself as an expert in the Ada-language. More as a developer fixing bugs/issues in *huge* Ada-code base. I understand you can not maintain all parsers, and see no problem helping you, but I can not give a guarantee/commit on fixing issues at short notice. My experience in parsers is low, so I will have a learning curve in that regard. I like to give it a try in making the Ada-parser better. Lets jump into the Ada-parser and we see how it goes. Koen

…

On Wed, 7 Apr 2021 at 22:28, Masatake YAMATO ***@***.***> wrote: Thank you. Could you consider being a maintainer of Ada parser? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2946 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUKTOWPDYAX3N6XGW3YEKTTHS55JANCNFSM42RLICEA> .