build-sys,main,mingw: Enable MANUAL_GLOBBING #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried this change in my MINGW64 environment. prints nothing. I wonder this is something to do with #2996 . |
On Windows, the shell doesn't expand wildcards. Ctags should expand them by ourselves. Also fixes universal-ctags#2996.
k-takata
force-pushed
the
mingw-manual-globbing
branch
from
6dde30e to
eed4431
Compare
Codecov Report
@@ Coverage Diff @@
## master #3072 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 200 200
Lines 47799 47799
=======================================
Hits 41756 41756
Misses 6043 6043
Continue to review full report at Codecov.
|
k-takata
changed the title
|
Codecov reports nothing about the change. It might be better to use codecov also in the MinGW environment. |
masatake
approved these changes
Aug 12, 2021
|
LGTM. Sorry to be late for the review. |
|
Thank you for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the shell doesn't expand wildcards.
Ctags should expand them by ourselves.
See also: #3014 (comment)