Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttcn: Skip comments correctly #3141

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Conversation

karolba
Copy link
Contributor

@karolba karolba commented Aug 28, 2021

Right now comments don't get skipped all the way, leading to code like

type enumerated Enum {
    /* a comment */
    Value
}

or

type enumerated Enum {
    // a comment
    Value
}

resulting in "Value" not being present in the output, due to getNonWhiteSpaceChar() returning '*' (for /* */comments) or '\n' (for // comments)

Right now comments don't get skipped all the way, leading to code like

    type enumerated Enum {
        /* a comment */
        Value
    }

or

    type enumerated Enum {
        // a comment
        Value
    }

resulting in "Value" not being present in the output
@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #3141 (f769ca3) into master (10c03fd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
- Coverage   84.90%   84.90%   -0.01%     
==========================================
  Files         200      200              
  Lines       47840    47842       +2     
==========================================
- Hits        40620    40619       -1     
- Misses       7220     7223       +3     
Impacted Files Coverage Δ
parsers/ttcn.c 93.22% <100.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c03fd...f769ca3. Read the comment docs.

@masatake masatake merged commit 61e20a6 into universal-ctags:master Aug 28, 2021
@masatake
Copy link
Member

@karolba, thank you.

I have a comment about your usage of git.
You used your master branch for making a pull request.
However, I recommend you make a topic branch for each pull request. So you can keep your master branch clean.
See https://git-scm.com/book/en/v2/Git-Branching-Branching-Workflows for more details.

I wrote this because I expect more contributions from you:-).
Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants