JavaScript: allow class methods get and set

[jafl]

get and set are used to define getters and setters for a class. However, get and set can also be method names. This patch adds support for the latter.

[masatake]

Could you remove the last commit 0b5c16a?

Saying frankly, I don't understand what it is. However, I guess, it is not a "must" for the purpose of this pull request.
If I'm wrong, please let me know.

[masatake]

@b4n, IF you have time, I would like to review this pull request.

@jafl, thank you.

[codecov]

Codecov Report

Merging #3329 (0b5c16a) into master (c4e3847) will decrease coverage by 0.00%.
The diff coverage is 70.83%.

❗ Current head 0b5c16a differs from pull request most recent head 661398c. Consider uploading reports for the commit 661398c to get more accurate results

@@            Coverage Diff             @@
##           master    #3329      +/-   ##
==========================================
- Coverage   85.44%   85.43%   -0.01%     
==========================================
  Files         216      216              
  Lines       50319    50337      +18     
==========================================
+ Hits        42993    43004      +11     
- Misses       7326     7333       +7     

Impacted Files	Coverage Δ
parsers/jscript.c	96.58% <70.83%> (-0.60%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e3847...661398c. Read the comment docs.

[jafl]

Once everything else looks good, I will include the .gitignore for gnulib, with a newline on the end, as a separate commit.

[masatake]

How about the following change?

A. if the token just read is "TOKEN_OPEN_PAREN", NextToken must be NULL.
Based on this assumption, we can remove 'NextToken == NULL' from the condition.

B. this parser assumes if(isKeyword(token, ...) ) {... has the same meaning if (isType (token, TOKEN_KEYWORD) && isKeyword(token, ...) {.... Therefore, if you assign non-TOKEN_KEYWORD to token->type, you may have to set KEYWORD_NONE to token->keyword.

diff --git a/parsers/jscript.c b/parsers/jscript.c
index a1be93576..1b8bc3108 100644
--- a/parsers/jscript.c
+++ b/parsers/jscript.c
@@ -1659,13 +1659,14 @@ static bool parseMethods (tokenInfo *const token, const tokenInfo *const class,
 			tokenInfo *savedToken = newToken ();
 			copyToken (savedToken, token, true);
 			readToken (token);
-			if (isType(token, TOKEN_OPEN_PAREN) && NextToken == NULL)
+			if (isType(token, TOKEN_OPEN_PAREN))
 			{
 				Assert (NextToken == NULL);
 				NextToken = newToken ();
 				copyToken (NextToken, token, false);	/* save token for next read */
 				copyToken (token, savedToken, true);	/* restore token to process */
 				token->type = TOKEN_IDENTIFIER;			/* process as identifier */
+				token->keyword	= KEYWORD_NONE;
 			}
 			else if (isKeyword (savedToken, KEYWORD_get))
 			{

[jafl]

Thanks for catching that!

[masatake]

Could you wait for a week till merging?
I wonder whether we can get a review from the main developer of the parser.

[jafl]

@masatake Note that I cannot merge any pull requests. You will have to do it when you feel comfortable.

[masatake]

@jafl, yes, I know.

I approved your pull request explicitly before merging just for recording what I did as the maintainer of this repository. I will merge your pull request this weekend.

[masatake]

Thank you.