-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readtags: print the input fields literally even if -E option is given #3578
readtags: print the input fields literally even if -E option is given #3578
Conversation
Does testing of the "roundtrip" way doesn't work on windows? |
942c52c
to
8f66862
Compare
Codecov ReportBase: 82.88% // Head: 82.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3578 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 223 223
Lines 54060 54060
=======================================
Hits 44809 44809
Misses 9251 9251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
03f73e4
to
d0e1264
Compare
It seems that _findfirst doesn't accept a file name including a tab or newline. |
9f5fda3
to
8f66862
Compare
Close universal-ctags#3559. On Windows, I could not pass a directory name including a tab or a newline character as the input for ctags. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
0acccea
to
35a4c10
Compare
Thanks. I don't know the code logic well but the test cases looks good to me. I think we still need to write about how Another problem is how could a client tool know if readtags has this patch. It's hard to do without a version number. |
@AmaiKinono Thank you for reviewing.
I will write it in "EXCEPTIONS IN UNIVERSAL CTAGS" or somewhere in tags(5).
I agree with you. I opened #3551. |
I wonder whether we can use the same version number in ctags and readtags. |
The extra issues pointed out by @AmaiKinono are traced by #3584 and #3551. |
Close #3559.
Signed-off-by: Masatake YAMATO yamato@redhat.com