Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readtags: print the input fields literally even if -E option is given #3578

Merged

Conversation

masatake
Copy link
Member

@masatake masatake commented Dec 4, 2022

Close #3559.

Signed-off-by: Masatake YAMATO yamato@redhat.com

@masatake
Copy link
Member Author

masatake commented Dec 4, 2022

Does testing of the "roundtrip" way doesn't work on windows?

@masatake masatake force-pushed the readtags--escaping-input-fields branch from 942c52c to 8f66862 Compare December 4, 2022 20:37
@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 82.88% // Head: 82.88% // No change to project coverage 👍

Coverage data is based on head (8f66862) compared to base (f9d21e7).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8f66862 differs from pull request most recent head 7b232b5. Consider uploading reports for the commit 7b232b5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3578   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files         223      223           
  Lines       54060    54060           
=======================================
  Hits        44809    44809           
  Misses       9251     9251           
Impacted Files Coverage Δ
extra-cmds/printtags.c 91.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masatake masatake marked this pull request as draft December 5, 2022 01:14
@masatake masatake added this to the 6.0 milestone Dec 5, 2022
@masatake masatake force-pushed the readtags--escaping-input-fields branch from 03f73e4 to d0e1264 Compare December 5, 2022 12:36
@masatake
Copy link
Member Author

masatake commented Dec 5, 2022

It seems that _findfirst doesn't accept a file name including a tab or newline.

@masatake masatake force-pushed the readtags--escaping-input-fields branch from 9f5fda3 to 8f66862 Compare December 5, 2022 15:01
Close universal-ctags#3559.

On Windows, I could not pass a directory name including a tab or a
newline character as the input for ctags.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake force-pushed the readtags--escaping-input-fields branch from 0acccea to 35a4c10 Compare December 5, 2022 16:28
@masatake masatake marked this pull request as ready for review December 5, 2022 18:28
@masatake masatake requested a review from AmaiKinono December 5, 2022 18:28
@AmaiKinono
Copy link
Member

Thanks. I don't know the code logic well but the test cases looks good to me.

I think we still need to write about how {tagfile} is printed in the manual, according to how it's actually implemented, so a client tool knows how to get the actual path.

Another problem is how could a client tool know if readtags has this patch. It's hard to do without a version number.

@masatake
Copy link
Member Author

masatake commented Dec 6, 2022

@AmaiKinono Thank you for reviewing.

I think we still need to write about how {tagfile} is printed in the manual, according to how it's actually implemented, so a client tool knows how to get the actual path.

I will write it in "EXCEPTIONS IN UNIVERSAL CTAGS" or somewhere in tags(5).
I would like you to review the text I will add. I opened #3584.

Another problem is how could a client tool know if readtags has this patch. It's hard to do without a version number.

I agree with you. I opened #3551.

@masatake
Copy link
Member Author

masatake commented Dec 6, 2022

I wonder whether we can use the same version number in ctags and readtags.

@masatake
Copy link
Member Author

masatake commented Dec 7, 2022

The extra issues pointed out by @AmaiKinono are traced by #3584 and #3551.

@masatake masatake merged commit 50ab7a7 into universal-ctags:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readtags: improper handling of escape sequences in input field
2 participants