D: remove overload, not a keyword
#3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presumably this was mistakenly added instead of override (which is also there). https://dlang.org/spec/lex.html#keywords `override` only appears before a function declaration. https://dlang.org/spec/function.html#virtual-functions
12 tasks
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3710 +/- ##
=======================================
Coverage 82.96% 82.96%
=======================================
Files 226 226
Lines 54969 54969
=======================================
Hits 45606 45606
Misses 9363 9363
☔ View full report in Codecov by Sentry. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably this was mistakenly added instead of
override(which is also there).https://dlang.org/spec/lex.html#keywords
overrideonly appears before a function declaration.https://dlang.org/spec/function.html#virtual-functions