Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htable: use precalculated list of primes #3739

Merged
merged 2 commits into from
May 31, 2023

Conversation

dtikhonov
Copy link
Member

This seems like it should work, @masatake -- what's a good way to test this code? There seem to be no unit tests for this.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b3e1ad7) 82.99% compared to head (f0bfcb2) 82.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3739   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         226      226           
  Lines       55039    55050   +11     
=======================================
+ Hits        45680    45691   +11     
  Misses       9359     9359           
Impacted Files Coverage Δ
extra-cmds/utiltest.c 100.00% <100.00%> (ø)
main/htable.c 80.64% <100.00%> (-0.18%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masatake
Copy link
Member

See https://github.com/universal-ctags/ctags/blob/master/extra-cmds/utiltest.c.

"make tutil" is the way to run the test.

@dtikhonov dtikhonov requested a review from masatake May 30, 2023 20:14
@dtikhonov dtikhonov merged commit 7731536 into universal-ctags:master May 31, 2023
@masatake
Copy link
Member

Thank you.

@dtikhonov
Copy link
Member Author

You're welcome! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants