-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatLab: return appropriate tags for set get methods + unit #3773
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3773 +/- ##
=======================================
Coverage 83.04% 83.04%
=======================================
Files 227 227
Lines 55184 55184
=======================================
Hits 45828 45828
Misses 9356 9356
☔ View full report in Codecov by Sentry. |
I'll merge this. Let me rearrange some commits before merging. |
For example: function get.myproperty(obj) ... Otherwise function tag returned is just 'get' instead of 'get.myproperty'. See matlab property set methods documentation [https://www.mathworks.com/help/matlab/matlab_oop/property-set-methods.html]] (@masatake updated this commit log.)
Tag returned should be get.myproperty f set.myproperty f (@masatake added --sort=no.)
After thinking, I dropped the man page. The VERSIONS section is for describing the change adding a kind, a role, a field, or an extra. |
I will merge this but I have some comments.
For the input, I think the parser should make a tag for
A class end: field is another field all the tags should have. |
That's fair. If there is somewhere else you would like me to put that information, or add anything else to the docs, I'm happy to do that. Also, the changes you've made are great! |
Thank you! |
Update function regexps for 'get.' and 'set.' methods. For example:
function get.myproperty(obj)
...
Otherwise function tag returned is just 'get' instead of 'get.myproperty'.
Replaces #3772