Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the need for dummy IP prefix. #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pimoz
Copy link

@Pimoz Pimoz commented May 10, 2021

List with no elements can be initialized as LIST = false; in BIRD and this is a correct syntax.

List with no elements can be initialized as LIST = false; in BIRD and this is a correct syntax.
@unixsurfer
Copy link
Owner

Hi @Pimoz,

Firstly, let me apologize for the very late response, but life has been very difficult the past period.

I am OK with this change but it is not backwards compatible, so it will break current installations which utilize older version of Bird.
You could add a logic to the check if dummy_ip_prefix setting is present and act accordingly.
What do you think?

Thanks a lot for your interested in the project and the time you spent to prepare this PR,
Pavlos

@Pimoz
Copy link
Author

Pimoz commented Jun 11, 2021

No problem, we all know how life can be :)

Yes you are right. I will prepare a fix so everything will be backwards compatible.

This project is great btw. Just what I needed.

@XioNoX
Copy link

XioNoX commented Aug 3, 2023

@Pimoz that sounds like a great improvement, I was wondering if you ended up writing that fix. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants