Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default export of json5 for parsing #135

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

sadeghbarati
Copy link
Contributor

πŸ”— Linked issue

None

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

on the Windows and Stackblitz environment, I have json5 error like TypeError: parse is not a function

https://www.npmjs.com/package/json5?activeTab=code


Please check this Stackblitz playground it has two c12 build files (.tgz)

  • file:c12-1.7.1.tgz ❌
  • file:c12-1.7.2.tgz βœ…

https://stackblitz.com/edit/vitejs-vite-kwdgy9

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 changed the title fix: json5 parse is not a function fix: use default export of json5 Feb 14, 2024
@pi0 pi0 changed the title fix: use default export of json5 fix: use default export of json5 for parsing Feb 14, 2024
@pi0 pi0 merged commit a00cbe5 into unjs:main Feb 14, 2024
2 checks passed
@sadeghbarati sadeghbarati deleted the fix/json5-parse-is-not-function branch February 14, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants