feat: allow disabling remote extend with giget: false
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pi0 Hey, I don't want to annoy you if you're busy. I would be really happy if you could give a quick feedback on this and if or how it could be merged. There is also another PR open for a while, just a quick comment would let us know that it has been seen and if it has a chance of being merged. This is a really valuable package and thank you for maintaining it with many other packages 🫡. |
pi0
reviewed
Aug 13, 2024
pi0
changed the title
pi0
changed the title
giget: false
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 76.92% 71.75% -5.17%
==========================================
Files 7 8 +1
Lines 806 616 -190
Branches 80 105 +25
==========================================
- Hits 620 442 -178
+ Misses 184 172 -12
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #180
When loading in user configs we don't always want to import remote non-trusted code in code-based config files (
.js,.ts, ...). This PR adds the option to disable remote extending while still supporting extensions of local config files.