-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(loader): scan for config keys files #210
base: main
Are you sure you want to change the base?
Conversation
So I've added some code, but I realise maybe it doesn't belong properly here. You're also right pi0 that glob won't be too efficient as I understand that in NodeJS implementations we scandir and then do picomatch. In any case, I was wondering that the first call to resolve config location, we get all files that contain the config name as a fragment (either with |
Thanks for PR. Some changes:
|
Thank you for the feedback (and patience as I have been context-switching as would you)!
Fair enough - I understand this may be expensive!
Now that you point that out, I realise that this feature is essentially the reverse of Over there, we have defaulted to 4 level-deep for generating templates of the config object. So based on my understanding of
I do agree with this point as well, but I would believe |
attempts to resolve #137
file tree example: