Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watchConfig): support hmr #78

Merged
merged 4 commits into from
Apr 19, 2023
Merged

feat(watchConfig): support hmr #78

merged 4 commits into from
Apr 19, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 19, 2023

Following up #77

This PR improves hooks with new acceptHMR lifecycle hook that allows handling config updates. Built-in getDiff uses ohash.diff internally to compare configs for easy implementation.

image

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #78 (0f2f060) into main (9cd11ef) will decrease coverage by 1.48%.
The diff coverage is 45.00%.

❗ Current head 0f2f060 differs from pull request most recent head c7a0ca9. Consider uploading reports for the commit c7a0ca9 to get more accurate results

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   79.61%   78.14%   -1.48%     
==========================================
  Files           5        5              
  Lines         672      700      +28     
  Branches       64       64              
==========================================
+ Hits          535      547      +12     
- Misses        137      153      +16     
Impacted Files Coverage Δ
src/watch.ts 36.95% <45.00%> (+1.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 12d850c into main Apr 19, 2023
@pi0 pi0 deleted the feat/hmr branch April 19, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant